From: Daniel Barkalow <barkalow@iabervon.org>
Date: Thu, 20 Mar 2008 17:12:38 GMT
Subject: Re: Invalid refspec?
Message-ID: <alpine.LNX.1.00.0803201256080.19665@iabervon.org>
In-Reply-To: <7vy78dwdh2.fsf@gitster.siamese.dyndns.org>

On Thu, 20 Mar 2008, Junio C Hamano wrote:

> Daniel Barkalow <barkalow@iabervon.org> writes:
> 
> > We need a test for the src being an object name around line 443 in 
> > remote.c; I'll have something this evening if nobody beats me to it.
> 
> Careful.  That is ONLY valid for pushes.  For fetches, you are allowed to
> name existing refs and nothing else.

I think it's okay to make "HEAD~1:foo" *valid* a fetch refspec; it'll be 
rejected a bit further along, but there's no particular need to give a 
different error for "HEAD~1:foo" versus 
"e83c5163316f89bfbde7d9ab23ca2e25604af290:foo" based on the presence of a 
~. Sure, we can figure out a little bit earlier that it's not going to 
work, but I don't think that's really enough to make it important that 
parse_ref_spec reject it.

	-Daniel
*This .sig left intentionally blank*