From: Daniel Barkalow <barkalow@iabervon.org>
Date: Sat, 08 Mar 2008 23:22:41 GMT
Subject: Re: [PATCH 05/11] Add a library function to add an alternate to the alternates file
Message-ID: <alpine.LNX.1.00.0803081820310.19665@iabervon.org>
In-Reply-To: <alpine.LSU.1.00.0803090017150.3975@racer.site>

On Sun, 9 Mar 2008, Johannes Schindelin wrote:

> Hi,
> 
> On Sat, 8 Mar 2008, Daniel Barkalow wrote:
> 
> 
> > +void add_to_alternates_file(const char *reference)
> > +{
> > +	char *file;
> > +	char *alt;
> > +	int fd;
> > +
> > +	file = mkpath("%s/objects/info/alternates", get_git_dir());
> > +	fd = open(file, O_CREAT | O_WRONLY | O_APPEND, 0666);
> > +	if (fd < 0)
> > +		die("failed to create %s", file);
> 
> Even with alternates, which are probably written only rarely, I would have 
> expected a lockfile procedure (if only to be consistent with the rest).

That's a good idea; I started with this inside clone, where you can be 
pretty certain not to get contention (and the shell version is using >> to 
update it), but in the library the lockfile is the right thing to do, so 
that other code can use it safely.

	-Daniel
*This .sig left intentionally blank*