From: Daniel Barkalow Date: Mon, 25 Feb 2008 06:35:27 GMT Subject: Re: [PATCH 2/2] Add support for url aliases in config files Message-ID: In-Reply-To: <7vfxvho8r7.fsf@gitster.siamese.dyndns.org> On Sun, 24 Feb 2008, Junio C Hamano wrote: > Daniel Barkalow writes: > > > Thanks; that's exactly what I would have done (assuming I didn't miss > > places like last time). Except that it should say that it's still > > undefined if you use: > > > > [url "foo"] > > insteadOf = "baz" > > [url "bar"] > > insteadOf = "baz/sub" > > > > in that you can't predict whether "baz/sub/a" will be "bar/a" or > > "foo/sub/a". This is actually what I'm most concerned about, since there > > is actually a logical expectation (the one that matches more will be used > > in preference to the less specific one), but that's not implemented. > > Someday, we'll probably want to implement it, and that'll change the > > behavior of this particular case. > > I'd say that that is a reasonable expectation, and it would be > fair to say that if we have it, the topic will be in 1.5.5 and > otherwise it won't. > > This might be a bit over-engineered, but should do the job. Very nice. And if we've got your over-engineered prefix-replacement code here, maybe I'll use it to also do the prefix-replacement for refspec patterns. Acked-by: Daniel Barkalow -Daniel *This .sig left intentionally blank*