From: Daniel Barkalow Date: Mon, 18 Feb 2008 17:15:55 GMT Subject: Re: [PATCH 4/4] Add a --cover-letter option to format-patch Message-ID: In-Reply-To: <7v4pc7udux.fsf@gitster.siamese.dyndns.org> On Sun, 17 Feb 2008, Junio C Hamano wrote: > Daniel Barkalow writes: > > > + argv[0] = "shortlog"; > > + argv[1] = head_sha1; > > + argv[2] = "--not"; > > + argv[3] = origin_sha1; > > + argv[4] = NULL; > > + fflush(stdout); > > + run_command_v_opt(argv, RUN_GIT_CMD); > > Please make it a habit to always append "--" disambiguator for > such command lines generated internally. In this case you are > not usinging short and common name like "master" or "HEAD" but > 40-letter-long hex string, so it is much less likely to get hit > by the "ambiguous rev vs file" rule, but even then it is still > possible that a work tree happens to have a file with the same > name. Sure. > > @@ -0,0 +1,101 @@ > > +$ git format-patch --stdout --cover-letter -n initial..master^ > > +From 9a6d4949b6b76956d9d5e26f2791ec2ceff5fdc0 Mon Sep 17 00:00:00 2001 > > +From: C O Mitter > > +Date: Mon, 26 Jun 2006 00:05:00 +0000 > > +Subject: [DIFFERENT_PREFIX 0/2] *** SUBJECT HERE *** > > + > > + > > +*** BLURB HERE *** > > + > > +A U Thor (2): > > + Second > > + Third > > + > > This probably falls within the "personal taste" category, but > I'd rather not to see two extra blank lines between Subject: and > BLURB HERE. The file is ugly with the double blank line, but I like it for what I think is the normal case, where you import the series into your mail reader, edit the cover letter there (where it appears as a message with some space devoted to the blurb by virtue of starting with now one blank line), and then send. In that context, I think it's nicer. -Daniel *This .sig left intentionally blank*