From: Daniel Barkalow Date: Mon, 18 Feb 2008 17:00:16 GMT Subject: Re: [PATCH 2/4] Export some email and pretty-printing functions Message-ID: In-Reply-To: <7vablzudvg.fsf@gitster.siamese.dyndns.org> On Sun, 17 Feb 2008, Junio C Hamano wrote: > Daniel Barkalow writes: > > > +void add_user_info(const char *what, enum cmit_fmt fmt, struct strbuf *sb, > > + const char *line, enum date_mode dmode, > > + const char *encoding); > > Exactly the same comment about "the function name being too > generic" from the last round still applies. pp_user_info() maybe? That also matches the other similar functions. -Daniel *This .sig left intentionally blank*