From: Daniel Barkalow Date: Wed, 06 Feb 2008 01:13:51 GMT Subject: Re: [PATCH 8/9] Use git diff instead of diff in t7201 Message-ID: In-Reply-To: <7v1w7r7yv0.fsf@gitster.siamese.dyndns.org> On Tue, 5 Feb 2008, Junio C Hamano wrote: > Daniel Barkalow writes: > > > Well, it's something I tripped over when builtin-checkout wasn't passing > > the tests and I couldn't figure out what it was doing wrong from the > > output. Like [3/9], it's relevant to evaluating whether the series works, > > even if it's not important for whether it actually does work. > > Yeah, using "diff -u" instead of just "diff" is an improvement > for debuggability which matters a lot in the test scripts. I think I asked before and didn't hear back (or maybe I got distracted and didn't ask); do you want this to use "diff -u" everywhere or "git diff" everywhere? This test is currently part "diff" and part "git diff", and I went for git diff" everywhere, but you seemed to prefer "diff -u". -Daniel *This .sig left intentionally blank*