From: Daniel Barkalow <barkalow@iabervon.org>
Date: Tue, 05 Feb 2008 20:38:35 GMT
Subject: Re: [PATCH 3/9] Send unpack-trees debugging output to stderr
Message-ID: <alpine.LNX.1.00.0802042118420.13593@iabervon.org>
In-Reply-To: <alpine.LSU.1.00.0802050117410.8543@racer.site>

On Tue, 5 Feb 2008, Johannes Schindelin wrote:

> Hi,
> 
> On Mon, 4 Feb 2008, Daniel Barkalow wrote:
> 
> >  #if DBRT_DEBUG > 1
> >  		if (first)
> > -			printf("index %s\n", first);
> > +			fprintf(stderr, "index %s\n", first);
> >  #endif
> 
> This code path is only affected when DBRT_DEBUG is defined ("Daniel 
> Barkalow's Roasted Tomatoes"?).  So technically, I do not really see why 
> this is part of this patch series...

"Daniel Barkalow's read_tree" (which is what that code was called when it 
was added). I needed to enable this debugging in order to debug this 
series, and found that enabling debugging caused tests to fail, so I fixed 
that in the series. To the extent that this matters at all, having it in 
the series that could need debugging makes sense.

	-Daniel
*This .sig left intentionally blank*