From: Nicolas Pitre <nico@fluxnic.net>
Date: Mon, 09 Sep 2013 19:56:20 GMT
Subject: Re: [PATCH v2 15/16] index-pack: use nr_objects_final as sha1_table size
Message-ID: <alpine.LFD.2.03.1309091553540.20709@syhkavp.arg>
In-Reply-To: <xmqqob813i9c.fsf@gitster.dls.corp.google.com>

On Mon, 9 Sep 2013, Junio C Hamano wrote:

> Nicolas Pitre <nico@fluxnic.net> writes:
> 
> > Do we know the actual number of objects to send during the capability 
> > negociation?
> 
> No, and that is not what I meant.  We know upfront after capability
> negotiation (by seeing a request to give them a thin-pack) that we
> will send, in addition to the usual packfile, the prefix that
> carries that information and that is the important part.  That lets
> the receiver decide whether to _expect_ to see the prefix or no
> prefix.  Without such, there needs some clue in the prefix part
> itself if there are prefixes that carry information computed after
> capability negotiation finished (i.e. after "object enumeration").

In this case, if negociation concludes on "thin" and "pack-version=4" 
then that could mean there is a prefix to be expected.


Nicolas