From: Nicolas Pitre <nico@fluxnic.net>
Date: Thu, 22 Aug 2013 23:35:17 GMT
Subject: Re: [PATCHv2 0/6] duplicate objects and delta cycles, oh my!
Message-ID: <alpine.LFD.2.03.1308221933450.14472@syhkavp.arg>
In-Reply-To: <20130822231215.GA16978@sigill.intra.peff.net>

On Thu, 22 Aug 2013, Jeff King wrote:

> On Thu, Aug 22, 2013 at 10:43:05AM -0400, Jeff King wrote:
> 
> > > write_idx_file() is called after index-pack processes all delta
> > > objects. Could resolve_deltas() go cyclic with certain duplicate
> > > object setup?
> > 
> > Good question. I'm not sure. I'll check it out.
> 
> I think the answer is "no", based on both reasoning and testing (both of
> which are included in patches 3-4 of the series below).
> 
> So here's my re-roll of the series.

This looks all good to me.


Acked-by: Nicolas Pitre <nico@fluxnic.net>


Nicolas