From: Linus Torvalds <torvalds@linux-foundation.org>
Date: Sat, 15 Aug 2009 21:29:33 GMT
Subject: Re: Simplify '--prett=xyz' options
Message-ID: <alpine.LFD.2.01.0908151422140.3162@localhost.localdomain>
In-Reply-To: <32541b130908151405j661cde8fh9783e91cebf1e398@mail.gmail.com>



On Sat, 15 Aug 2009, Avery Pennarun wrote:
> 
> I'm guessing that "after header" was just an implementation error.  It
> was presumably intended to be "after commit", so that the only
> difference between format and tformat is the presence or absence of
> the very last terminator.
> 
> Maybe the correct fix is just to make tformat not broken?

I do agree. 'tformat' is broken. But my point was more that 'tformat' was 
introduced for all the wrong reasons (ie that 'format' was broken, and 
then instead of fixing 'format', people introduced 'tformat' with a 
_different_ brokenness).

		Linus