From: Nicolas Pitre <nico@fluxnic.net>
Date: Mon, 15 Feb 2010 19:29:56 GMT
Subject: Re: [PATCH] don't use mmap() to hash files
Message-ID: <alpine.LFD.2.00.1002151426350.1946@xanadu.home>
In-Reply-To: <32541b131002151119o2f528ddv147d71d12d9d11fe@mail.gmail.com>

On Mon, 15 Feb 2010, Avery Pennarun wrote:

> On Mon, Feb 15, 2010 at 12:48 AM, Nicolas Pitre <nico@fluxnic.net> wrote:
> > Ideally you don't keep volatile objects into huge packs.  That's why we
> > have .keep to flag those packs that are huge and pure so not to touch
> > them anymore.
> 
> Of course the problem here is that as soon as you import a single
> (possibly volatile) 2GB file, your pack becomes "huge."  So these
> heuristics stop working very well and start to need some revision.

You don't have to repack that often though.  In which case the 
single-object 2GB pack might be discarded before the next repack.  And 
loose objects are packed into a pack of their own more often than 
multiple packs being repacked into a single pack.  So I think the 
current heuristics should still work pretty well.


Nicolas