From: Linus Torvalds <torvalds@linux-foundation.org>
Date: Mon, 11 Jan 2010 15:43:51 GMT
Subject: Re: [PATCH] grep: do not do external grep on skip-worktree entries
Message-ID: <alpine.LFD.2.00.1001110739280.13040@localhost.localdomain>
In-Reply-To: <7vvdf9402f.fsf@alter.siamese.dyndns.org>



On Sun, 10 Jan 2010, Junio C Hamano wrote:
> 
> Here is an experimental patch; first, some numbers (hot cache best of 5 runs).

Without testing it, I can already ACK it. It looks like the 
ObviouslyRightThing(tm) to do. But I'll run some numbers too.

One thing that worries me - but that is independent of this patch - is 
that I don't think our 'grep' function works correctly (neither the 
'fixmatch()' one or the 'regexec()' one) when there are NUL characters in 
a file. Maybe I shouldn't care, but it worries me a bit.

		Linus