From: Nicolas Pitre Date: Thu, 07 Jan 2010 17:58:01 GMT Subject: Re: base85: Two tiny fixes Message-ID: In-Reply-To: <201001071558.30065.agruen@suse.de> On Thu, 7 Jan 2010, Andreas Gruenbacher wrote: > While looking at the base85 code I found a bug in the debug code and an > unnecessary call. You may want to have a look at the two fixes here: > > http://www.kernel.org/pub/scm/linux/kernel/git/agruen/git.git ACK. Please post them to this list. > There is another little oddity in the way the de85 table is set up: 0 > indicates an invalid entry; to avoid this from clashing with a valid entry, > valid entries are incremented by one and decremented again while decoding. > This leads to slightly worse code than using a negative number to indicate > invalid values (and avoiding to increment/decrement). You can make a patch to modify that as well if you wish. And in that case don't forget to make de85 explicitly signed as a char is unsigned by default on some platforms. Nicolas