From: Linus Torvalds <torvalds@linux-foundation.org>
Date: Tue, 01 Sep 2009 03:27:03 GMT
Subject: Re: Improve on 'approxidate'
Message-ID: <alpine.LFD.2.00.0908311725260.21913@eeepc.linux-foundation.org>
In-Reply-To: <20090830223558.GA29807@coredump.intra.peff.net>



On Sun, 30 Aug 2009, Jeff King wrote:
> 
> This breaks relative dates like "3.months.ago", because
> approxidate_alpha needs to see the "current" date in tm (and now it sees
> -1, subtracts from it, and assumes we are just crossing a year boundary
> because of the negative).  3.years.ago is also broken, but I don't think
> 3.days.ago is.

Gaah. Thanks for noticing and the fixes. I had tested the relative modes, 
but only the "fixed offset" ones (days, hours, minutes, seconds), not the 
months and years cases.

			Linus