From: Nicolas Pitre Date: Tue, 18 Aug 2009 20:49:43 GMT Subject: Re: [PATCH] block-sha1: Windows declares ntohl() in winsock2.h Message-ID: In-Reply-To: <7v7hx0c1at.fsf@alter.siamese.dyndns.org> On Tue, 18 Aug 2009, Junio C Hamano wrote: > Meh, our mails crossed. I'll chuck this one and use your > > [PATCH] make sure byte swapping is optimal for git > > patch. Do you want default_swab32 be mmoved inside the > > #if defined(__GNUC__) && (defined(__i386__) || defined(__x86_64__)) > > block? Not necessarily. It is generic code that other compilers/architectures might use as well. Nicolas