From: Nicolas Pitre <nico@cam.org>
Date: Sun, 22 Mar 2009 19:23:27 GMT
Subject: Re: [PATCH v2 2/2] pack-objects: don't loosen objects available in alternate or kept packs
Message-ID: <alpine.LFD.2.00.0903221522341.30483@xanadu.home>
In-Reply-To: <7viqm15qda.fsf@gitster.siamese.dyndns.org>

On Sun, 22 Mar 2009, Junio C Hamano wrote:

> If you allow (last_found == NULL), the loop iterates over packed_git list,
> and when it has its last element in p after discovering nothing matches
> the criteria, this happens:
> 
> 	if (p == last_found) /* false, p is the last element on the list */
>         	p = packed_git; /* not taken */
> 	else
>         	p = p->next; /* taken, p == NULL now */
> 	if (p == last_found) /* true! */
> 		p = p->next; /* OOPS */

Yeah, you got it.  Now I remember.


Nicolas