From: Linus Torvalds <torvalds@linux-foundation.org>
Date: Wed, 17 Dec 2008 21:02:42 GMT
Subject: Re: [PATCH 8/5] combine-diff.c: use strbuf_readlink()
Message-ID: <alpine.LFD.2.00.0812171300070.14014@localhost.localdomain>
In-Reply-To: <7v63lileqh.fsf@gitster.siamese.dyndns.org>



On Wed, 17 Dec 2008, Junio C Hamano wrote:
> -			result[len] = 0;
> +			result_size = buf.len;
> +			result = strbuf_detach(&buf, NULL);

If result_size was made size_t, this would be

	result = strbuf_detach(&buf, &result_size);

But whether it makes any difference, I dunno.

Anyway, Ack on the 6-8 additions.

		Linus