From: Nicolas Pitre Date: Fri, 12 Dec 2008 00:55:32 GMT Subject: Re: [PATCH] autodetect number of CPUs by default when using threads Message-ID: In-Reply-To: <7v63lqcptn.fsf@gitster.siamese.dyndns.org> On Thu, 11 Dec 2008, Junio C Hamano wrote: > Nicolas Pitre writes: > > > I've spent quite a while wondering why repacking in one repo was faster > > than repacking in a clone of that repo on the same machine. So let's > > display how many threads are actually used. > > > > We have comprehensive test in Makefile to determine if threads are > > available, just to not use them by default. I think that code has > > proven itself for long enough now not to let people benefit from it. > > Hmm, it does appear that distros compile with THREADED_DELTA_SEARCH turned > on (I only checked Fedora and Debian), and I tend to agree with "long > enough" but "proven itself" feels bit too strong a statement. > > I think defaulting to autodetect is a good change. I do not like to add > new output to stderr deep in -rc, though. > > Can we park this in 'next' and move it to 'master' after 1.6.1? Sure. This is probably best for next. Nicolas