From: Nicolas Pitre <nico@cam.org>
Date: Tue, 12 Aug 2008 18:26:52 GMT
Subject: Re: [PATCH] pack-objects: Allow missing base objects when creating thin packs
Message-ID: <alpine.LFD.1.10.0808121426100.22892@xanadu.home>
In-Reply-To: <20080812181843.GD31092@spearce.org>

On Tue, 12 Aug 2008, Shawn O. Pearce wrote:

> Nicolas Pitre <nico@cam.org> wrote:
> > On Tue, 12 Aug 2008, Shawn O. Pearce wrote:
> > > +# Clone patch_clone indirectly by cloning base and fetching.
> > > +#
> > > +test_expect_success \
> > > +    'indirectly clone patch_clone' \
> > > +    '(mkdir user_clone &&
> > > +      cd user_clone &&
> > > +      git init &&
> > > +      git pull ../.git &&
> > > +      test $(git rev-parse HEAD) = $B
> > > +
> > > +      git pull ../patch_clone/.git &&
> > > +      test $(git rev-parse HEAD) = $C
> > > +     )
> > > +    '
> > 
> > What if the first test command fails?  Won't its result be ignored?
> 
> Isn't the exit status of the subshell the exit status of the last
> command in the subshell?

I'm not talking about the last command but the "test $(git rev-parse 
HEAD) = $B" line.


Nicolas