From: Linus Torvalds <torvalds@linux-foundation.org>
Date: Tue, 05 Aug 2008 00:21:03 GMT
Subject: Re: Not going beyond symbolic links
Message-ID: <alpine.LFD.1.10.0808041719380.3299@nehalem.linux-foundation.org>
In-Reply-To: <7vej5543v5.fsf_-_@gitster.siamese.dyndns.org>



On Mon, 4 Aug 2008, Junio C Hamano wrote:
> 
> I started to revisit this issue and patched "git update-index --add"
> and "git add" so far.  Patches follow.

Patches look good to me, but did you check the performance impact?

The rewritten 'has_symlink_leading_path()' should do ok, but it migth 
still be a huge performance downside to check all the paths for things 
like "git add -u".

I didn't test, though.

		Linus