From: Nicolas Pitre <nico@cam.org>
Date: Mon, 14 Jul 2008 02:27:18 GMT
Subject: Re: [PATCH 0/4] Honor core.deltaBaseCacheLimit during index-pack
Message-ID: <alpine.LFD.1.10.0807132220570.12484@xanadu.home>
In-Reply-To: <1216001267-33235-1-git-send-email-spearce@spearce.org>

On Sun, 13 Jul 2008, Shawn O. Pearce wrote:

> This should resolve the obscene memory usage of index-pack when
> resolving deltas for very large files.
> 
> Shawn O. Pearce (4):
>   index-pack: Refactor base arguments of resolve_delta into a struct
>   index-pack: Chain the struct base_data on the stack for traversal
>   index-pack: Track the object_entry that creates each base_data
>   index-pack: Honor core.deltaBaseCacheLimit when resolving deltas

Well... 

I don't like this.  Not your patch, but rather the direction this whole 
thing took in the first place, and now we have to bolt extra complexity 
on top.

I have the feeling this is not the best approach, especially since many 
long delta chains are going deep and all those intermediate objects are 
simply useless once the _only_ delta child has been resolved and 
therefore could be freed right away instead.

But I have to sleep on it first.


Nicolas