From: Nicolas Pitre <nico@cam.org>
Date: Wed, 05 Mar 2008 18:47:22 GMT
Subject: Re: [PATCH] shortlog: take the first populated line of the description
Message-ID: <alpine.LFD.1.00.0803051346200.2947@xanadu.home>
In-Reply-To: <1204727050.0@pinky>

On Wed, 5 Mar 2008, Andy Whitcroft wrote:

> 
> Way back the perl version of shortlog would take the first populated line
> of the commit body.  The builtin version mearly takes the first line.
> This leads to empty shortlog entries when there is some viable text in
> the commit.
> 
> Reinstate this behaviour igoring all lines with nothing but whitespace.
> 
> Signed-off-by: Andy Whitcroft <apw@shadowen.org>
> ---
> 
> 	This seems to be an improvement, returning to the original
> 	behaviour.  I cannot think of any good reason not to take the first
> 	populated line for a shortlog.	The alternative less agressive
> 	compromise might be to skip only completly empty lines at the
> 	start, but I am not sure that adds any value.
> 
> 	I seem to get a lot of these in converted SVN commits.
> 
> 	Comments?

Maybe it is the SVN conversion that needs fixing?


Nicolas