From: Nicolas Pitre <nico@cam.org>
Date: Sun, 17 Feb 2008 18:44:01 GMT
Subject: Re: [PATCH] RFC: git lazy clone proof-of-concept
Message-ID: <alpine.LFD.1.00.0802171335470.2732@xanadu.home>
In-Reply-To: <20080217081841.GS24004@spearce.org>

On Sun, 17 Feb 2008, Shawn O. Pearce wrote:

> Nicolas Pitre <nico@cam.org> wrote:
> > 
> > I should really come around to fixing packed_object_info_detail() for 
> > the OBJ_OFS_DELTA case one day.
> 
> Please don't.
> 
> Obtaining the SHA-1 of your delta base would require unpacking your
> delta base and then doing a SHA-1 hash of it.  Or alternatively
> doing a search through the .idx for the object that starts at the
> requested OFS.

I intended to use the pack index of course.  And the code already exists 
in pack-objects as find_packed_object().

> Either way, its really expensive for a minor detail
> of output in verify-pack.

Not _that_ expensive actually.  Like I say, in pack-objects we do it all 
the time.

> But if you are going to do that, you may also want to fix the
> "*store_size = 0 /* notyet */" that's like 5 lines above.  :)

Yeah, that's easy too.


Nicolas