From: Linus Torvalds Date: Thu, 14 Feb 2008 17:04:59 GMT Subject: Re: git-status producing incorrect results Message-ID: In-Reply-To: <20080214164505.GA21932@coredump.intra.peff.net> On Thu, 14 Feb 2008, Jeff King wrote: > > The patch below fixes it by discarding and re-reading the index if we > are doing a partial commit ACK. The partial commit case really should discard the index. > but I suspect it may just be papering over > the problem again. We probably need to have two separate index_states, > and pass in the correct one to wt-status (rather than giving it the > filename and having it read into the_index). ACK again, that's almost certainly the right long-term fix, but it essentially requires a "copy_index()" thing that creates a new index from an existing copy (so that we don't need to re-read it) etc infrastructure changes, so I think your patch is the correct one for now. Linus