From: Linus Torvalds <torvalds@linux-foundation.org>
Date: Wed, 16 Jan 2008 20:08:58 GMT
Subject: Re: [PATCH 2/2] close_lock_file(): new function in the lockfile API
Message-ID: <alpine.LFD.1.00.0801161207220.2806@woody.linux-foundation.org>
In-Reply-To: <7vejchr3pf.fsf_-_@gitster.siamese.dyndns.org>



On Wed, 16 Jan 2008, Junio C Hamano wrote:
> +
> +void close_lock_file(struct lock_file *lk)
> +{
> +	close(lk->fd);
> +	lk->fd = -1;
> +}

Since one of the main purposes of closing would be the error testing of 
writes that haven't made it out yet on filesystems like NFS that do 
open-close cache serialization, I'd suggest doing this as

	int close_lock_file(struct lock_file *lk)
	{
		int fd = lk->fd;
		lk->df = -1;
		return close(fd);
	} 

to give the return code.

		Linus