From: Nicolas Pitre <nico@cam.org>
Date: Mon, 17 Dec 2007 03:13:38 GMT
Subject: Re: [PATCH v2] threaded pack-objects: Use condition variables for thread communication.
Message-ID: <alpine.LFD.0.999999.0712162203470.8467@xanadu.home>
In-Reply-To: <200712162045.34456.johannes.sixt@telecom.at>

On Sun, 16 Dec 2007, Johannes Sixt wrote:

> Signed-off-by: Johannes Sixt <johannes.sixt@telecom.at>

One micro nit:

> +		for (;;) {
> +			for (i = 0; !target && i < delta_search_threads; i++)
> +				if (!p[i].working)
> +					target = &p[i];
> +			if (target)
> +				break;
> +			pthread_cond_wait(&progress_cond, &progress_mutex);
> +		};

There's a spurious ; here.

Otherwise:

Acked-by: Nicolas Pitre <nico@cam.org>


Nicolas