From: Linus Torvalds <torvalds@linux-foundation.org>
Date: Tue, 18 Dec 2007 16:50:01 GMT
Subject: Re: [PATCH] Add format-patch option --no-name-prefix.
Message-ID: <alpine.LFD.0.9999.0712180840060.21557@woody.linux-foundation.org>
In-Reply-To: <4767EE6D.5070509@obry.net>



On Tue, 18 Dec 2007, Pascal Obry wrote:

> Johannes Sixt a écrit :
> > that we need another diff option for it. Ok, on my keyboard 0 is typed
> > with the right hand, and 1 with the left hand, but... ??
> 
> Because you just did not read my follow-up message :)
> 
> I need this has I do not have the way to change the server applying the
> patch. So nothing wrong with my hands or fingers :)

Well, we'd also need something like that for doing recursive diffs of 
submodules (since then we'd want to do the internal diff with the 
submodule name appended to the prefix), so I do think this whole 
"--prefix" makes sense. 

But I obviously think the version by Dscho is better (exactly because it's 
*not* enough to just clear the name prefix entirely), although I think 
that one is broken too - using ':' to separate the prefixes is *not* 
acceptable, since ':' is very possibly part of the prefix.

So I think you'd need separate arguments for the from/to prefixes, and not 
try to shoehorn it into one argument. With possibly some simple form to 
say "no prefix". So maybe something like

  --src-prefix=<string>		// default "a/"
  --dst-prefix=<string>		// default "b/"
  --no-prefix			// shorthand for --src-prefix="" --dst-prefix=""

would work for everybody?

		Linus