From: Linus Torvalds <torvalds@linux-foundation.org>
Date: Mon, 29 Oct 2007 04:37:29 GMT
Subject: Re: [RFH] gcc constant expression warning...
Message-ID: <alpine.LFD.0.999.0710282136410.30120@woody.linux-foundation.org>
In-Reply-To: <alpine.LFD.0.9999.0710282053590.22100@xanadu.home>



On Sun, 28 Oct 2007, Nicolas Pitre wrote:
> 
> The test must also make sure off_t isn't signed, since in that case it 
> can only hold 31 bits.

Sinc eneither 31 _nor_ 32 bits is really enough, it's perfectly fine to 
just check that the size of "off_t" is *bigger* than 4 bytes, which my 
pseudo-patch did.

		Linus