From: Linus Torvalds <torvalds@linux-foundation.org>
Date: Tue, 23 Oct 2007 02:32:02 GMT
Subject: Re: What's cooking in git/spearce.git (topics)
Message-ID: <alpine.LFD.0.999.0710221930330.30120@woody.linux-foundation.org>
In-Reply-To: <20071022071644.GA7290@coredump.intra.peff.net>


Sorry, I missed this while being busy hacking and not reading email ;)

On Mon, 22 Oct 2007, Jeff King wrote:
> 
> Patch is below (please just squash with the one from Linus).

Your patch is better than what used to be there, but

> -			/* Already picked as a destination? */
> +			/* Already picked as a source? */
>  			if (!p->src_dst)
>  				continue;

the above is wrong, the whole thing should be dropped (we *want* to be 
able to re-use sources).

Anyway, the set of fixes I sent out earlier included fixing that stupid 
loop as one of the things.

		Linus