From: Nicolas Pitre <nico@cam.org>
Date: Wed, 30 May 2007 02:57:06 GMT
Subject: Re: [PATCH] diff-delta: use realloc instead of xrealloc
Message-ID: <alpine.LFD.0.99.0705292252220.11491@xanadu.home>
In-Reply-To: <7v1wgz5gus.fsf@assigned-by-dhcp.cox.net>

On Tue, 29 May 2007, Junio C Hamano wrote:

> Martin Koegler <mkoegler@auto.tuwien.ac.at> writes:
> 
> > Commit 83572c1a914d3f7a8dd66d954c11bbc665b7b923 changed many
> > realloc to xrealloc. This change was made in diff-delta.c too,
> > although the code can handle an out of memory failure.
> >
> > This patch reverts this change in diff-delta.c.
> 
> Wasn't there a discussion around this exact issue when the
> original patch was applied?

Maybe, but I cannot remember it, not can I justify that xrealloc now.


Nicolas