From: Nicolas Pitre <nico@cam.org>
Date: Tue, 01 May 2007 18:39:54 GMT
Subject: Re: [PATCH 4/8] git-repack --max-pack-size: add fixup_header_footer()
Message-ID: <alpine.LFD.0.98.0705011438490.6574@xanadu.home>
In-Reply-To: <56b7f5510705011058y89e4aa4p8f8b7eccde30af78@mail.gmail.com>

On Tue, 1 May 2007, Dana How wrote:

> I was in the middle of creating pack-write.c at Shawn's suggestion. It 
> will only contain fixup_header_footer(), to be called by fast-import.c 
> and builtin-pack-object.c.  index-pack.c also has 
> readjust_pack_header_and_sha1(), which is compatible except it doesn't 
> close the file.  I was going to leave it alone for now.  This new file 
> should be the logical place to put other common pack-writing-related 
> things.  Please barf now if you don't think I should do this tiny 
> refactoring at this point.

That's fine.  Please go ahead.


Nicolas