From: Keith Cascio <keith@cs.ucla.edu>
Date: Fri, 03 Apr 2009 00:04:18 GMT
Subject: Re: [PATCH] Allow setting default diff options via diff.defaultOptions
Message-ID: <alpine.GSO.2.00.0904021647120.16242@kiwi.cs.ucla.edu>
In-Reply-To: <alpine.DEB.1.00.0903210415110.10279@pacific.mpi-cbg.de>

Johannes,

On Sat, 21 Mar 2009, Johannes Schindelin wrote:

> The idea is from Keith Cascio.
> 
> Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
> ---
> 	I do not particularly like what this patch does, but I like
> 	the non-intrusiveness and conciseness of it.

Your patch does not provide a command line opt_out flag.  Let me describe a 
workflow situation and ask you how to handle it if the user were running your 
patch.  Let diff.defaultOptions = "-b".  The user is getting closer to 
submitting his patch and he wants to see patch output identical to what `git format-patch`
will produce.  What command should he use?

      `git format-patch --stdout master` ?

                                  -- Keith