From: Matthew DeVore <matvore@comcast.net>
Date: Tue, 23 Oct 2018 17:55:49 GMT
Subject: Re: [RFC 2/2] exclude-promisor-objects: declare when option is allowed
Message-ID: <alpine.DEB.2.21.1810231053550.56374@matvore-linux.svl.corp.google.com>
In-Reply-To: <xmqqin1ts11h.fsf@gitster-ct.c.googlers.com>



On Tue, 23 Oct 2018, Junio C Hamano wrote:

> Not really.  We were already doing a controlled failure via die(),
> so these two tests would not have caught the problem in the code
> before the fix in this patch.
>

BUG is apparently considered a "wrong" failure and not a controlled one
by test_must_fail. I just double-checked that the tests fail without
this patch.

not ok 119 - --exclude-promisor-objects does not BUG-crash
# 
#		test_must_fail git blame --exclude-promisor-objects one
# 
# failed 1 among 119 test(s)
1..119