From: Johannes Schindelin <johannes.schindelin@gmx.de>
Date: Mon, 04 Dec 2017 14:18:25 GMT
Subject: Re: [PATCH v2 2/2] git-prompt: fix reading files with windows line endings
Message-ID: <alpine.DEB.2.21.1.1712041516280.98586@virtualbox>
In-Reply-To: <20171201233133.30011-2-rabel@robertabel.eu>

Hi Robert,

1/2 looks very good.

On Sat, 2 Dec 2017, Robert Abel wrote:

> If any of the files read by __git_eread have \r\n line endings, read
> will only strip \n, leaving \r. This results in an ugly prompt, where
> instead of
> 
>     user@pc MINGW64 /path/to/repo (BARE:master)
> 
> the last parenthesis is printed over the beginning of the prompt like
> 
>     )ser@pc MINGW64 /path/to/repo (BARE:master

Maybe mention explicitly what Gabór said about $'...' being supported by
Bash and zsh, the only two intended users of git-prompt.sh (and there
being precedent of that construct being used already e.g. in __git_ps1)?

Other than that, this looks very good to me.

Thanks,
Johannes