From: Johannes Schindelin <johannes.schindelin@gmx.de>
Date: Thu, 30 Nov 2017 15:21:22 GMT
Subject: Re: [PATCH] git-prompt: fix reading files with windows line endings
Message-ID: <alpine.DEB.2.21.1.1711301619590.6482@virtualbox>
In-Reply-To: <cacbf41e-3b4a-99e2-a0e0-50bb4cd9e152@robertabel.eu>

Hi Robert,

On Thu, 30 Nov 2017, Robert Abel wrote:

> So reading a dummy variable along with the actual content variable
> works for git-prompt:
> 
>     __git_eread ()
>     {
>         local f="$1"
>         local dummy
>         shift
>         test -r "$f" && IFS=$'\r\n' read "$@" dummy < "$f"
>     }
> 
> I feel like this would be the most readable solution thus far.

Hmm. I am just a little concerned about "dummy" swallowing the rest of the
line, e.g. when reading "1 2 3" via `__git_eread line`... the way I read
it, dummy would consume "2 3" and line would *not* receive "1 2 3" but
only "1"...

Ciao,
Johannes