From: Johannes Schindelin <johannes.schindelin@gmx.de>
Date: Fri, 03 Nov 2017 11:54:56 GMT
Subject: Re: [PATCH v2 4/6] list-objects: filter objects in traverse_commit_list
Message-ID: <alpine.DEB.2.21.1.1711031254280.6482@virtualbox>
In-Reply-To: <20171102123245.0f768968703ec4e35d3d1f81@google.com>

Hi Jonathan,

On Thu, 2 Nov 2017, Jonathan Tan wrote:

> On Thu,  2 Nov 2017 17:50:11 +0000
> Jeff Hostetler <git@jeffhostetler.com> wrote:
> 
> > +int parse_list_objects_filter(struct list_objects_filter_options *filter_options,
> > +			      const char *arg)
> 
> Returning void is fine, I think. It seems that all your code paths
> either return 0 or die.

Can we please start to encourage libified code, rather than discourage it?

Thank you,
Dscho