From: Johannes Schindelin Date: Thu, 08 Jun 2017 10:22:35 GMT Subject: Re: [PATCH 5/9] t1308: relax the test verifying that empty alias values are disallowed Message-ID: In-Reply-To: <20170607181553.GE110638@google.com> Hi Brandon, On Wed, 7 Jun 2017, Brandon Williams wrote: > On 06/07, Johannes Schindelin wrote: > > We are about to change the way aliases are expanded, to use the early > > config machinery. > > > > This machinery reports errors in a slightly different manner than the > > cached config machinery. > > Not a comment on the patch but just a genuine question: Is there any > reason why they complain in a different way? Doesn't it make sense for > the errors to be reported consistently? Yes, I agree that they should not complain in different ways. I had a brief look to see whether I could quickly fix that "while at it". But it seems to be quite a bit more involved than I am comfortable slipping into this patch series (whose purpose is not to fix the dichotomy between direct and cached config parsing, after all). Ciao, Dscho