From: Johannes Schindelin Date: Wed, 03 May 2017 15:09:51 GMT Subject: Re: [PATCH v2 06/21] attr.c: use fopen_or_warn() Message-ID: In-Reply-To: <20170503101706.9223-7-pclouds@gmail.com> Hi Duy, On Wed, 3 May 2017, Nguyễn Thái Ngọc Duy wrote: > Signed-off-by: Nguyễn Thái Ngọc Duy As commented about warn_on_fopen_errors(), I do not see a benefit in separating the introduction of this small function from the individual files' changes to use it. Let's bring it all together. Ciao, Dscho