From: Johannes Schindelin <johannes.schindelin@gmx.de>
Date: Tue, 02 May 2017 15:40:07 GMT
Subject: Re: [PATCH v3 4/6] Documentation: move rebase.* config variables to a separate rebase-config.txt
Message-ID: <alpine.DEB.2.20.1705021736470.3480@virtualbox>
In-Reply-To: <20170502040048.9065-5-liambeguin@gmail.com>

Hi Liam,


On Tue, 2 May 2017, Liam Beguin wrote:

> Move configuration variables to a separate file in order to remove
> duplicates, and include it in config.txt and git-rebase.txt.
> The new descriptions are taken from config.txt as they are more verbose.

This is a nice cleanup in its own right. My only complaint: the
rebase.autoStash documentation no longer says that it is related to the
command-line option `--autosquash`.

While the original description in `git-rebase.txt` was suboptimal, maybe
we can add back the reference by adding something like:

	This option can be overridden by the `--no-autosquash` and
	`--autosquash` options of linkgit:git-rebase[1].

Ciao,
Johannes