From: Johannes Schindelin <johannes.schindelin@gmx.de>
Date: Tue, 02 May 2017 15:34:57 GMT
Subject: Re: [PATCH v3 3/6] rebase -i: add short command-name in --autosquash
Message-ID: <alpine.DEB.2.20.1705021732570.3480@virtualbox>
In-Reply-To: <20170502040048.9065-4-liambeguin@gmail.com>

Hi Liam,

On Tue, 2 May 2017, Liam Beguin wrote:

> teach `git rebase -i` to recognise short command-names when using the
> '--autosquash' option. This allows commit with titles beginning with
> "s! ..." and "f! ..." to be treated the same way as "squash! ..." and
> "fixup! ..." respectively.

As the recommended way to generate those commits is by using the
--fixup/--squash options of git-commit, and as there is *a much higher*
chance of false positives when using a very short tell-tale such as `f!`
(which could be an abbreviation for an expletive, likewise `s!`), I do not
think we will want this change.

Let's keep handling just fixup!/squash!

Ciao,
Johannes