From: Johannes Schindelin <johannes.schindelin@gmx.de>
Date: Mon, 02 Jan 2017 10:39:46 GMT
Subject: Re: [PATCH] mingw: add a regression test for pushing to UNC paths
Message-ID: <alpine.DEB.2.20.1701021121041.3469@virtualbox>
In-Reply-To: <6d69b529-a42c-9f93-f342-7c6c19170285@kdbg.org>

Hi Hannes,

On Fri, 23 Dec 2016, Johannes Sixt wrote:

> Am 23.12.2016 um 18:11 schrieb Johannes Schindelin:
> 
> > +test_expect_success setup '
> > +	test_commit initial
> > +'
> > +
> > +test_expect_success clone '
> > +	git clone "file://$UNCPATH" clone
> > +'
> > +
> > +test_expect_success push '
> > +	(
> > +		cd clone &&
> > +		git checkout -b to-push &&
> > +		test_commit to-push &&
> > +		git push origin HEAD
> > +	)
> > +'
> > +
> > +test_done
> 
> Wouldn't at a minimum
> 
> test_expect_success 'check push result' '
> 	git rev-parse to-push
> '
> 
> be a good idea to make sure that the pushed commit actually arrived?

Sure.

Ciao,
Dscho