From: Johannes Schindelin Date: Wed, 30 Nov 2016 12:30:47 GMT Subject: Re: [PATCH v3 1/2] difftool: add a skeleton for the upcoming builtin Message-ID: In-Reply-To: <20161129204915.lo45b2jz57dlfug5@sigill.intra.peff.net> Hi Peff, On Tue, 29 Nov 2016, Jeff King wrote: > On Tue, Nov 29, 2016 at 09:36:55PM +0100, Johannes Schindelin wrote: > > > So the suggestion by both you and Peff, to use an environment variable, > > which is either global, or requires the user to set it manually per > > session, is simply not a good idea at all. > > No, my suggestion was to use config and have the test suite use an > environment variable to test both cases (preferably automatically, > without the user having to do anything). > > I do not see how that fails to cover all of your use cases. Oh, so the suggestion is to have *both* a config *and* an environment variable. That is not elegant. Ciao, Dscho