From: Johannes Schindelin <johannes.schindelin@gmx.de>
Date: Fri, 02 Sep 2016 07:32:07 GMT
Subject: Re: [PATCH 27/34] sequencer (rebase -i): differentiate between comments and 'noop'
Message-ID: <alpine.DEB.2.20.1609020931450.129229@virtualbox>
In-Reply-To: <1472746523.4680.30.camel@kaarsemaker.net>

Hi Dennis,

On Thu, 1 Sep 2016, Dennis Kaarsemaker wrote:

> /*
>  * Note that ordering matters in this enum. Not only must it match the
>  * mapping below, it is also divided into several sections that matter.
>  * When adding new commands, make sure you add it in the right section.
>  */
> enum todo_command {
> 	/* All commands that handle commits */
> 	TODO_PICK,
> 	...
> 	/* All commands that do something else than pick */
> 	TODO_EXEC,
> 	...
> 	/* All commands that do nothing but are counted for reporting progress */
> 	TODO_NOOP,
> 	...
> 	/* Comments, which are not counted
> 	TODO_COMMENT
> }

I like it! Changed accordingly.

Thanks!
Dscho