From: Johannes Schindelin Date: Thu, 01 Sep 2016 14:57:46 GMT Subject: Re: [PATCH 20/34] sequencer (rebase -i): copy commit notes at end Message-ID: In-Reply-To: <1472714431.4680.1.camel@kaarsemaker.net> Hi Dennis, On Thu, 1 Sep 2016, Dennis Kaarsemaker wrote: > On wo, 2016-08-31 at 10:55 +0200, Johannes Schindelin wrote: > > +               if (!stat(rebase_path_rewritten_list(), &st) && > > +                               st.st_size > 0) { > > +                       struct child_process child = CHILD_PROCESS_INIT; > > + > > +                       child.in = open(rebase_path_rewritten_list(), O_RDONLY); > > +                       child.git_cmd = 1; > > +                       argv_array_push(&child.args, "notes"); > > +                       argv_array_push(&child.args, "copy"); > > +                       argv_array_push(&child.args, "--for-rewrite=rebase"); > > +                       /* we don't care if this copying failed */ > > +                       run_command(&child); > > +               } > > I know this is a strict port of git-rebase--interactive.sh, but > shouldn't we at least warn the user that the copy failed? At this point, I want to have as faithful a conversion as possible (except that I do not care for the speed of git-rebase--interactive.sh, of course). Besides, I am fairly certain that a failure will result in an error message. We just do not act on the exit value. Ciao, Dscho