From: Johannes Schindelin <johannes.schindelin@gmx.de>
Date: Mon, 29 Aug 2016 15:43:41 GMT
Subject: Re: [PATCH 01/20] cache: convert struct cache_entry to use struct object_id
Message-ID: <alpine.DEB.2.20.1608291743060.129229@virtualbox>
In-Reply-To: <577f6266-42ec-6c7b-8b21-1e4997f2b816@gmail.com>

Hi Kuba,

On Mon, 29 Aug 2016, Jakub Narębski wrote:

> W dniu 29.08.2016 o 01:27, brian m. carlson pisze:
> 
> > Convert struct cache_entry to use struct object_id by applying the
> > following semantic patch and the object_id transforms from contrib:
> > 
> > @@
> > struct cache_entry E1;
> > @@
> > - E1.sha1
> > + E1.oid.hash
> > 
> > @@
> > struct cache_entry *E1;
> > @@
> > - E1->sha1
> > + E1->oid.hash
> 
> I wonder if writing this patch series (or rather the following one)
> would be helped by using one of semantic patch tools, such as
> Coccinelle[1], spdiff[2], or Undebt[3]...
> 
> [1]: http://coccinelle.lip6.fr/

If previous work by Brian is any indication, he did use Coccinelle and the
commit message actually shows the definition used for the transformation.

Ciao,
Johannes