From: Johannes Schindelin Date: Fri, 26 Aug 2016 13:40:34 GMT Subject: Re: [PATCH 04/15] sequencer: lib'ify prepare_revs() Message-ID: In-Reply-To: Hi Junio, On Thu, 25 Aug 2016, Junio C Hamano wrote: > Johannes Schindelin writes: > > > To be truly useful, the sequencer should never die() but always return > > an error. > > > > Signed-off-by: Johannes Schindelin > > --- > > I am still looking at sequencer.c in 'master', but I do not think > that the sole caller of this function, walk_revs_populate_todo(), > is prepared to act on an error return from this function and instead > it expects this to die() when in trouble. And I do not think I saw > the function touched in the steps so far. > > So this step smells like a fishy conversion to me. The fishy part is, of course, that I managed not to realize that the patch libifiying walk_revs_populate_todo() came *after* this patch that libified one of its callees, prepare_revs(). FWIW the same is true for sequencer_pick_revisions(), which was libified way too late in the game. This is once again a demonstration that a final patch series does *not* reflect the process of developing it: in this case, the order of the patches is the *opposite* of their development, as I libified functions from the lowest, deepest call depth up to the top-level functions. Fixed in v2, Dscho