From: Johannes Schindelin <johannes.schindelin@gmx.de>
Date: Tue, 21 Jun 2016 12:03:27 GMT
Subject: Re: [PATCH] Make find_commit_subject() more robust
Message-ID: <alpine.DEB.2.20.1606211402320.22630@virtualbox>
In-Reply-To: <xmqqeg7ru00i.fsf@gitster.mtv.corp.google.com>

Hi Junio,

On Mon, 20 Jun 2016, Junio C Hamano wrote:

> Johannes Schindelin <johannes.schindelin@gmx.de> writes:
> 
> > Just like the pretty printing machinery, we should simply ignore empty
> > lines at the beginning of the commit messages.
> >
> > This discrepancy was noticed when an early version of the rebase--helper
> > produced commit objects with more than one empty line between the header
> > and the commit message.
> >
> > Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
> > ---
> > Published-As: https://github.com/dscho/git/releases/tag/leading-empty-lines-v1
> >
> > 	Aaaaand another patch from the rebase--helper front. I guess I'll
> > 	call it a day with this one.
> 
> Makes sense.  This has a trivial textual conflict with cleanup
> patches in flight, I think, but that is not a big problem.

I will gladly resend rebased to `next`, if you wish.

> It does hint that we might want to find a library function that can
> replace a hand-rolled while loop we are adding here, though ;-)

Heh. I cannot help you with that ;-)

> Perhaps cast this new behaviour in stone by adding a test?

Will do.

Ciao,
Dscho