From: Johannes Schindelin Date: Mon, 20 Jun 2016 07:01:30 GMT Subject: Re: [PATCH v2 0/8] object_id part 4 Message-ID: In-Reply-To: <20160619092448.GA12221@sigill.intra.peff.net> Hi Peff, On Sun, 19 Jun 2016, Jeff King wrote: > I think traditionally we've avoided struct assignment because some > ancient compilers didn't do it. But it's in C89, and I suspect it's > crept into the code base anyway over the years without anyone > complaining. I fear that's my fault, at least partially, seeing as merge-recursive.c even *returns* structs (see 6d297f81; I plan to fix that as part of the cleaned-up am-3-merge-recursive-direct patch series). Sorry, Dscho