From: Johannes Schindelin <johannes.schindelin@gmx.de>
Date: Fri, 13 May 2016 13:16:51 GMT
Subject: Re: [PATCH v2 3/3] Add a perf test for rebase -i
Message-ID: <alpine.DEB.2.20.1605131515410.4092@virtualbox>
In-Reply-To: <xmqqr3d8jnvo.fsf@gitster.mtv.corp.google.com>

Hi Junio,

On Wed, 11 May 2016, Junio C Hamano wrote:

> Johannes Schindelin <johannes.schindelin@gmx.de> writes:
> 
> > diff --git a/t/perf/p3404-rebase-interactive.sh b/t/perf/p3404-rebase-interactive.sh
> > new file mode 100755
> > index 0000000..382163c
> > --- /dev/null
> > +++ b/t/perf/p3404-rebase-interactive.sh
> > @@ -0,0 +1,31 @@
> > +#!/bin/sh
> > +
> > +test_description='Tests rebase -i performance'
> > +. ./perf-lib.sh
> > +
> > +test_perf_default_repo
> > +
> > +# This commit merges a sufficiently long topic branch for reasonable
> > +# performance testing
> > +branch_merge=ba5312d
> > +export branch_merge
> 
> t/perf/README mentions the possibility to use your own repository as
> a test data via GIT_PERF_REPO, but doing so would obviously break
> this test.

Right.

> I wonder if there is a way to say "running this perf script with
> custom GIT_PERF_REPO is not supported" and error out.  That may
> help other existing tests that (incorrectly) assume that their test
> data is this project (if there is any).

Good point. I will change it so that the test is skipped if that commit is
not found.

Ciao,
Dscho