From: Johannes Schindelin Date: Wed, 11 May 2016 06:57:02 GMT Subject: Re: [PATCH v8 3/3] submodule: ensure that -c http.extraheader is heeded Message-ID: In-Reply-To: Hi Junio, On Tue, 10 May 2016, Junio C Hamano wrote: > Johannes Schindelin writes: > > > To support this developer's use case of allowing build agents token-based > > access to private repositories, we introduced the http.extraheader > > feature, allowing extra HTTP headers to be sent along with every HTTP > > request. > > > > This patch verifies that we can configure these extra HTTP headers via the > > command-line for use with `git submodule update`, too. Example: git -c > > http.extraheader="Secret: Sauce" submodule update --init > > > > Signed-off-by: Johannes Schindelin > > --- > > Applying this directly on top of the other two fails, and when > merged with jk/submodule-c-credential, the test passes. > > Which is exactly what we expect to see. Nice. Good. > I'll merge jk/submodule-c-credential into js/http-custom-headers > that already has 1 & 2, and then apply this. An alternative would > be to hold this and wait until both jk/submodule-c-credential and > js/http-custom-headers with 1 & 2 graduates and then apply this, > which is a lot inferior option. As long as it ends up in 2.9.0, I am happy with whatever path these patches take ;-) Thanks, Dscho